Skip to content

Add stubs for NumberFormatter (Intl) #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add stubs for NumberFormatter (Intl) #4827

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

No description provided.

kocsismate
kocsismate commented Oct 14, 2019
View reviewed changes
@cmb69 cmb69 added the Stubs label Oct 15, 2019
@cmb69 cmb69 self-requested a review February 3, 2020 11:32
@kocsismate kocsismate force-pushed the intl-formatter-stubs branch from 0b9e96a to 02ef1f6 Compare February 4, 2020 14:40
@kocsismate
Copy link
Member Author

@cmb69 Just a heads-up that I rebased the branch yesterday so that you can review it whenever you have time for it :)

cmb69
cmb69 reviewed Feb 9, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments; also all annotations (except for the @return annotations for the methods) can now be expressed in the code, since we're supporting union types.

Otherwise looks good to me. Thanks!

@kocsismate kocsismate force-pushed the intl-formatter-stubs branch from 02ef1f6 to a4b9f67 Compare February 9, 2020 19:30
@kocsismate kocsismate force-pushed the intl-formatter-stubs branch from a4b9f67 to 4f56046 Compare February 9, 2020 19:52
@php-pulls php-pulls closed this in 86780ff Feb 9, 2020
@kocsismate kocsismate deleted the intl-formatter-stubs branch February 9, 2020 21:14
@kocsismate
Copy link
Member Author

Thank you for the review :)

@nikic
Copy link
Member

nikic commented Feb 10, 2020

Looks like we're getting close: https://gist.github.com/nikic/e56d77a32b33a351d95e3dc3529caa6a

Down to mysqli (for which there is a PR already), a few remainders of intl, and oci8, pgsql, spl, xslt.

@kocsismate
Copy link
Member Author

Down to mysqli (for which there is a PR already), a few remainders of intl, and oci8, pgsql, spl, xslt.

Yep :) I was planning to deal with the rest of the intl ext (although I left some of the biggest components to the end) and review mysqli in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @nikic @cmb69